-
Notifications
You must be signed in to change notification settings - Fork 144
[disputes] Code generation: update services and models #1634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers an automated update to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces automated changes to the disputes service models and API client, primarily focused on code formatting and style updates. While most changes align with standard Java conventions, such as updating indentation from 2 to 4 spaces, there are several inconsistencies and formatting issues introduced by the generation tool. My review focuses on these regressions to help improve the generator's output for future updates. Key issues include inconsistent indentation of class members, malformed Javadocs, and minor style violations that affect readability.
| * @return an instance of the actual schema/object | ||
| */ | ||
| @JsonValue | ||
| public Object getActualInstance() {return instance;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| * | ||
| * @param instance the actual instance of the schema/object | ||
| */ | ||
| public void setActualInstance(Object instance) {this.instance = instance;} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, it's good practice to add a space after the opening brace { and before the closing brace } in single-line method implementations.
| public void setActualInstance(Object instance) {this.instance = instance;} | |
| public void setActualInstance(Object instance) { this.instance = instance; } |
| if (object.getActualInstance() == null) { | ||
| return null; | ||
| } else if (object.getActualInstance() instanceof AbstractOpenApiSchema) { | ||
| return getActualInstanceRecursively((AbstractOpenApiSchema)object.getActualInstance()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| private boolean isSetDisputePspReference = false; | ||
|
|
||
| public static final String JSON_PROPERTY_MERCHANT_ACCOUNT_CODE = "merchantAccountCode"; | ||
| public static final String JSON_PROPERTY_MERCHANT_ACCOUNT_CODE = "merchantAccountCode"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| /** | ||
| * Create an instance of AcceptDisputeRequest given an JSON string | ||
| * | ||
| * @param jsonString JSON string | ||
| * @return An instance of AcceptDisputeRequest | ||
| * @throws JsonProcessingException if the JSON string is invalid with respect to | ||
| * AcceptDisputeRequest | ||
| * @throws JsonProcessingException if the JSON string is invalid with respect to AcceptDisputeRequest | ||
| */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc for the fromJson method is incorrectly formatted. The opening /** should be on its own line and properly indented to align with the method declaration. This issue appears to be present for toJson methods and across multiple model classes in this PR, likely due to a misconfiguration in the code generation tool.
| /** | |
| * Create an instance of AcceptDisputeRequest given an JSON string | |
| * | |
| * @param jsonString JSON string | |
| * @return An instance of AcceptDisputeRequest | |
| * @throws JsonProcessingException if the JSON string is invalid with respect to | |
| * AcceptDisputeRequest | |
| * @throws JsonProcessingException if the JSON string is invalid with respect to AcceptDisputeRequest | |
| */ | |
| /** | |
| * Create an instance of AcceptDisputeRequest given an JSON string | |
| * | |
| * @param jsonString JSON string | |
| * @return An instance of AcceptDisputeRequest | |
| * @throws JsonProcessingException if the JSON string is invalid with respect to AcceptDisputeRequest | |
| */ |
| * @param acceptDisputeRequest {@link AcceptDisputeRequest } (required) | ||
| * @return {@link AcceptDisputeResponse } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Javadoc formatting has some minor issues:
- There's an extra space before
(required). - There's an unnecessary blank line before the
@returntag.
This seems to be a consistent issue across all method Javadocs in this file, likely from the auto-generation process.
| * @param acceptDisputeRequest {@link AcceptDisputeRequest } (required) | |
| * @return {@link AcceptDisputeResponse } | |
| * @param acceptDisputeRequest {@link AcceptDisputeRequest } (required) | |
| * @return {@link AcceptDisputeResponse } |
bf00a13 to
ca927ec
Compare
62dd6b5 to
13e6d4a
Compare
This PR contains the automated changes for the
disputesservice.The commit history of this PR reflects the
adyen-openapicommits that have been applied.