Skip to content

Conversation

@AdyenAutomationBot
Copy link
Collaborator

This PR contains the automated changes for the disputes service.

The commit history of this PR reflects the adyen-openapi commits that have been applied.

@AdyenAutomationBot AdyenAutomationBot requested review from a team as code owners January 5, 2026 15:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @AdyenAutomationBot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers an automated update to the disputes service, incorporating the latest code generation output from adyen-openapi. The changes are largely cosmetic, focusing on standardizing code style, import order, and Javadoc formatting across various model and API interaction files to maintain consistency and readability.

Highlights

  • Automated Code Generation Update: This pull request is an automated update to the disputes service models and API, reflecting recent changes from the adyen-openapi generation process.
  • Code Style and Formatting: The primary changes across numerous Java model files involve reordering imports, adding blank lines for readability, and minor adjustments to Javadoc comments and method formatting (e.g., equals, hashCode).
  • API Service File Refinement: The DisputesApi.java file also received formatting updates, including import reordering and Javadoc adjustments.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces automated changes to the disputes service models and API client, primarily focused on code formatting and style updates. While most changes align with standard Java conventions, such as updating indentation from 2 to 4 spaces, there are several inconsistencies and formatting issues introduced by the generation tool. My review focuses on these regressions to help improve the generator's output for future updates. Key issues include inconsistent indentation of class members, malformed Javadocs, and minor style violations that affect readability.

* @return an instance of the actual schema/object
*/
@JsonValue
public Object getActualInstance() {return instance;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, it's good practice to add a space after the opening brace { and before the closing brace } in single-line method implementations.

Suggested change
public Object getActualInstance() {return instance;}
public Object getActualInstance() { return instance; }

*
* @param instance the actual instance of the schema/object
*/
public void setActualInstance(Object instance) {this.instance = instance;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, it's good practice to add a space after the opening brace { and before the closing brace } in single-line method implementations.

Suggested change
public void setActualInstance(Object instance) {this.instance = instance;}
public void setActualInstance(Object instance) { this.instance = instance; }

if (object.getActualInstance() == null) {
return null;
} else if (object.getActualInstance() instanceof AbstractOpenApiSchema) {
return getActualInstanceRecursively((AbstractOpenApiSchema)object.getActualInstance());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It's a common Java style convention to have a space after a type cast for better readability.

Suggested change
return getActualInstanceRecursively((AbstractOpenApiSchema)object.getActualInstance());
return getActualInstanceRecursively((AbstractOpenApiSchema) object.getActualInstance());

private boolean isSetDisputePspReference = false;

public static final String JSON_PROPERTY_MERCHANT_ACCOUNT_CODE = "merchantAccountCode";
public static final String JSON_PROPERTY_MERCHANT_ACCOUNT_CODE = "merchantAccountCode";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The indentation for this constant is inconsistent with the one defined on line 38. JSON_PROPERTY_DISPUTE_PSP_REFERENCE has 2-space indentation while this one has 4. Please ensure consistent indentation for class members. This issue is present in several other model classes in this PR.

Comment on lines 215 to 221
/**
* Create an instance of AcceptDisputeRequest given an JSON string
*
* @param jsonString JSON string
* @return An instance of AcceptDisputeRequest
* @throws JsonProcessingException if the JSON string is invalid with respect to
* AcceptDisputeRequest
* @throws JsonProcessingException if the JSON string is invalid with respect to AcceptDisputeRequest
*/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc for the fromJson method is incorrectly formatted. The opening /** should be on its own line and properly indented to align with the method declaration. This issue appears to be present for toJson methods and across multiple model classes in this PR, likely due to a misconfiguration in the code generation tool.

Suggested change
/**
* Create an instance of AcceptDisputeRequest given an JSON string
*
* @param jsonString JSON string
* @return An instance of AcceptDisputeRequest
* @throws JsonProcessingException if the JSON string is invalid with respect to
* AcceptDisputeRequest
* @throws JsonProcessingException if the JSON string is invalid with respect to AcceptDisputeRequest
*/
/**
* Create an instance of AcceptDisputeRequest given an JSON string
*
* @param jsonString JSON string
* @return An instance of AcceptDisputeRequest
* @throws JsonProcessingException if the JSON string is invalid with respect to AcceptDisputeRequest
*/

Comment on lines 65 to 67
* @param acceptDisputeRequest {@link AcceptDisputeRequest } (required)
* @return {@link AcceptDisputeResponse }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Javadoc formatting has some minor issues:

  • There's an extra space before (required).
  • There's an unnecessary blank line before the @return tag.

This seems to be a consistent issue across all method Javadocs in this file, likely from the auto-generation process.

Suggested change
* @param acceptDisputeRequest {@link AcceptDisputeRequest } (required)
* @return {@link AcceptDisputeResponse }
* @param acceptDisputeRequest {@link AcceptDisputeRequest } (required)
* @return {@link AcceptDisputeResponse }

@AdyenAutomationBot AdyenAutomationBot force-pushed the sdk-automation/disputes branch 4 times, most recently from bf00a13 to ca927ec Compare January 8, 2026 14:34
@galesky-a galesky-a closed this Jan 12, 2026
@galesky-a galesky-a deleted the sdk-automation/disputes branch January 12, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants